NIFI-14477: Add the ability to configure jetty http compliance#9876
NIFI-14477: Add the ability to configure jetty http compliance#9876taz1988 wants to merge 1 commit intoapache:mainfrom
Conversation
exceptionfactory
left a comment
There was a problem hiding this comment.
Thanks for proposing this new property @taz1988.
Based on the issue description, I'm not in favor of moving forward with this new property as the first attempted solution.
Fundamentally, this is an issue with the client system, in this case Apache Knox. Changes should be made to that project, versus introducing non-standard behavior into Apache NiFi.
Taking a closer look at the issue, however, does it make a difference when NiFi is configured for HTTP/1.1, as opposed to the default of HTTP/2 with fallback to HTTP/1.1?
|
@taz1988 Following up on this PR, any feedback from the Apache Knox project on making changes there? |
exceptionfactory
left a comment
There was a problem hiding this comment.
@taz1988 I'm closing the pull request for now, but feel free to follow up on the Jira issue with any related updates. As mentioned, this seems like something to pursue with the Apache Knox project. If there are other reasons to support a configurable compliance level, it seems better to configure a single value versus supporting individual settings. Glad to discuss further on the Jira issue for additional consideration.
Summary
NIFI-00000
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation