Skip to content

Comments

NIFI-14477: Add the ability to configure jetty http compliance#9876

Closed
taz1988 wants to merge 1 commit intoapache:mainfrom
taz1988:NIFI-14477
Closed

NIFI-14477: Add the ability to configure jetty http compliance#9876
taz1988 wants to merge 1 commit intoapache:mainfrom
taz1988:NIFI-14477

Conversation

@taz1988
Copy link
Contributor

@taz1988 taz1988 commented Apr 14, 2025

Summary

NIFI-00000

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 21

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for proposing this new property @taz1988.

Based on the issue description, I'm not in favor of moving forward with this new property as the first attempted solution.

Fundamentally, this is an issue with the client system, in this case Apache Knox. Changes should be made to that project, versus introducing non-standard behavior into Apache NiFi.

Taking a closer look at the issue, however, does it make a difference when NiFi is configured for HTTP/1.1, as opposed to the default of HTTP/2 with fallback to HTTP/1.1?

@exceptionfactory
Copy link
Contributor

@taz1988 Following up on this PR, any feedback from the Apache Knox project on making changes there?

Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@taz1988 I'm closing the pull request for now, but feel free to follow up on the Jira issue with any related updates. As mentioned, this seems like something to pursue with the Apache Knox project. If there are other reasons to support a configurable compliance level, it seems better to configure a single value versus supporting individual settings. Glad to discuss further on the Jira issue for additional consideration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants