NIFI-13531 ExecuteSQLRecord not honouring FlowFile attributes for con…

[fmaretic]

…figured RecordWriter.

Summary

NIFI-13531

These are the following changes:

• New MockCsvRecordWriter utility class with a fluent builder and an option to configure a dynamic separator.
• Changes to existing MockRecordWriter class to support dynamic separators.
• Bugfix in the RecordSqlWriter class that was providing an empty Map instead of the original attributes when constructing a RecordSetWriter.

One thing to note here is that this could (in theory) break some existing flows if the users are aware of the issue and made some workarounds for it. This is in fact a breaking change if the users are not relying on this behavior.

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

• Apache NiFi Jira issue created

Pull Request Tracking

• Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
• Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

• Pull Request based on current revision of the main branch
• Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

• Build completed using mvn clean install -P contrib-check
• JDK 21

Licensing

• New dependencies are compatible with the Apache License 2.0 according to the License Policy
• New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

• Documentation formatting appears as expected in rendered files

[joewitt]

@markap14 This change looks good to me and the tests seem helpful. Can you review as I dont think I appreciate the potentially breaking nature of it in carrying through attributes...

[github-actions]

Automated review is marking this PR as stale due to lack of updates in the past four months. This PR will be closed in 15 days if the stale label is not removed. This stale label and automated closure does not indicate a judgement of the PR, just lack of reviewer bandwidth and helps us keep the PR queue more manageable. If you would like this PR re-opened you can do so and a committer can remove the stale label. Or you can open a new PR. Try to help review other PRs to increase PR review bandwidth which in turn helps yours.

[exceptionfactory]

Thanks for the work on this @fmaretic. The updated Mock Writer is useful as shown in the new test method. I'm in favor of moving forward with this change to the RecordSqlWriter. Can you rebase the pull request to resolve the current merge conflict?

[fmaretic]

Hello @exceptionfactory , I have rebased the branch.

[exceptionfactory]

Thanks again @fmaretic! +1 merging