Skip to content

NIFI-14541 Add Scoped Authorization for Flow Registry Clients#9918

Closed
exceptionfactory wants to merge 1 commit intoapache:mainfrom
exceptionfactory:NIFI-14541
Closed

NIFI-14541 Add Scoped Authorization for Flow Registry Clients#9918
exceptionfactory wants to merge 1 commit intoapache:mainfrom
exceptionfactory:NIFI-14541

Conversation

@exceptionfactory
Copy link
Contributor

Summary

NIFI-14541 Adds scoped authorization for listing, adding, modifying, and removing Flow Registry Clients.

The changes are compatible with existing authorization policies based on the read and write access to the Controller resource. Introducing a new Registry Client Resource Type aligns with other component authorization, and enables authorization checking for operations on Flow Registry Clients nested under the Controller resource.

The StandardFlowRegistryClientNode already returns the Controller resource as the parent authorizable object, supporting nested authorization checking.

Enabling the standard Managed Authorizer and configuring a Flow Registry Client exercises new authorization checking against existing policies at the Controller level.

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 21

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

- Added Registry Client Resource Type with path nested under Controller
- Updated Controller Resource Flow Registry Client methods to use new Authorizable resolution
Copy link
Contributor

@pvillard31 pvillard31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes @exceptionfactory - it looks straightforward and thanks for fixing uuid versus id, I believe this should be fixed in some other places in this ControllerResource class but it is definitely not critical. I also noticed some inconsistencies with the SecurityRequirement annotations and the permissions on potential referenced controller services but I don't think we need to go into that level of details of registry clients. +1, merging

@pvillard31 pvillard31 closed this in cd1ff92 May 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants