NIFI-14541 Add Scoped Authorization for Flow Registry Clients#9918
Closed
exceptionfactory wants to merge 1 commit intoapache:mainfrom
Closed
NIFI-14541 Add Scoped Authorization for Flow Registry Clients#9918exceptionfactory wants to merge 1 commit intoapache:mainfrom
exceptionfactory wants to merge 1 commit intoapache:mainfrom
Conversation
- Added Registry Client Resource Type with path nested under Controller - Updated Controller Resource Flow Registry Client methods to use new Authorizable resolution
pvillard31
approved these changes
May 7, 2025
Contributor
pvillard31
left a comment
There was a problem hiding this comment.
Thanks for the changes @exceptionfactory - it looks straightforward and thanks for fixing uuid versus id, I believe this should be fixed in some other places in this ControllerResource class but it is definitely not critical. I also noticed some inconsistencies with the SecurityRequirement annotations and the permissions on potential referenced controller services but I don't think we need to go into that level of details of registry clients. +1, merging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-14541 Adds scoped authorization for listing, adding, modifying, and removing Flow Registry Clients.
The changes are compatible with existing authorization policies based on the read and write access to the Controller resource. Introducing a new Registry Client Resource Type aligns with other component authorization, and enables authorization checking for operations on Flow Registry Clients nested under the Controller resource.
The
StandardFlowRegistryClientNodealready returns the Controller resource as the parent authorizable object, supporting nested authorization checking.Enabling the standard Managed Authorizer and configuring a Flow Registry Client exercises new authorization checking against existing policies at the Controller level.
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation