NIFI-14566 - Introduce Inject Metadata Output Strategy in ConsumeKafka

[pvillard31]

Summary

NIFI-14566 - Introduce Inject Metadata Output Strategy in ConsumeKafka

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

• Apache NiFi Jira issue created

Pull Request Tracking

• Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
• Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

• Pull Request based on current revision of the main branch
• Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

• Build completed using mvn clean install -P contrib-check
  • JDK 21

Licensing

• New dependencies are compatible with the Apache License 2.0 according to the License Policy
• New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

• Documentation formatting appears as expected in rendered files

[joewitt]

This is really helpful Pierre and lets people inject any/all kafka metadata into the records against their original schema as they might wish. I intent to verify some behavior soon and will share results but by all means somoene else reviewing first go for it

[exceptionfactory]

Thanks for the work on this additional output strategy @pvillard31! The general implementation looks good. I noted several minor recommendations, and highlighted one case where null handling was unclear.

[joewitt]

the change from a user pov looks good and lets us inject the kafkaMetadata into the record nicely.

the verify method is broken but seems unrelated. I'm good with this if @exceptionfactory feedback is otherwise good

[exceptionfactory]

Thanks for making the adjustments @pvillard31, and thanks for the review @joewitt, I agree that the latest implementation looks good. +1 merging