Fix for NUTCH-2245 NGram Model for Cosine Similarity by bhavyasanghavi#101
Fix for NUTCH-2245 NGram Model for Cosine Similarity by bhavyasanghavi#101bhavyasanghavi wants to merge 1 commit intoapache:masterfrom
Conversation
|
Description:
Use Case: |
|
|
||
| //Check if user has specified n for ngram cosine model | ||
| int ngram = conf.getInt("scoring.similarity.ngrams", 1); | ||
| LOG.info("Value of ngram: "+ngram); |
There was a problem hiding this comment.
Please use correct effficient slf4j code notation here
e.g. LOG.info("Value of ngram: {} ", ngram);
There was a problem hiding this comment.
Yes, I will update that. Thanks.
|
Overall, the patch it looking excellent. |
| tStream.reset(); | ||
| while(tStream.incrementToken()) { | ||
| String term = charTermAttribute.toString(); | ||
| LOG.info(term); |
There was a problem hiding this comment.
This seems like its used for debugging, please change it to LOG.debug(). It helps keeping the log clean.
Thanks!
1b10444 to
1c14474
Compare
|
I have tried out the patch, works as expected, going to commit now. |
No description provided.