NUTCH-2285 Digest Authentication support for Nutch 2.X REST API.#126
Closed
kamaci wants to merge 4 commits intoapache:2.xfrom
kamaci:NUTCH-2285
Closed
NUTCH-2285 Digest Authentication support for Nutch 2.X REST API.#126kamaci wants to merge 4 commits intoapache:2.xfrom kamaci:NUTCH-2285
kamaci wants to merge 4 commits intoapache:2.xfrom
kamaci:NUTCH-2285
Conversation
| AuthenticationTypeEnum authenticationType = configManager.get(ConfigResource.DEFAULT) | ||
| .getEnum("restapi.auth", AuthenticationTypeEnum.NONE); | ||
|
|
||
| if (authenticationType == AuthenticationTypeEnum.NONE) { |
Member
There was a problem hiding this comment.
Please change to the more efficient switch notation. Multiple If's are messy and JDK1.8 has better switch support for string input values.
Member
Author
There was a problem hiding this comment.
@lewismc I've added switch with enum support.
Member
Author
|
@lewismc this PR is ready to check for merging. |
Member
Author
|
I'll create a new pull request which does not have conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.