Skip to content

fix for Nutch 1973 by sujen1412 #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sujen1412 wants to merge 18 commits into from
Closed

fix for Nutch 1973 by sujen1412 #16

sujen1412 wants to merge 18 commits into from

Conversation

@sujen1412
Copy link
Member

@sujen1412 sujen1412 commented Apr 1, 2015

API calls documented at - https://wiki.apache.org/nutch/Nutch_1.X_RESTAPI.
This pull request includes Index, Generate, Fetch, Parse, Update, InvertLinks, Dedup and Readdb jobs.

@lewismc
Copy link
Member

lewismc commented Apr 1, 2015

Can you please take a look at the formatting style for Nutch code ?

On Tuesday, March 31, 2015, Sujen Shah notifications@github.com wrote:

API calls documented at - https://wiki.apache.org/nutch/Nutch_1.X_RESTAPI.
This pull request includes Index, Generate, Fetch, Parse, Update,

InvertLinks, Dedup and Readdb jobs.

You can view, comment on, or merge this pull request online at:

#16
Commit Summary

  • Created NutchSever.java
  • Added cmd line option to start NutchServer on user specified port
  • Added JobInfo Response object
  • Added Configuration end point
  • Update ivy.xml
  • Request response objects for Configuration support
  • Merge branch 'NUTCH-1931' of https://github.com/sujen1412/nutch into
    NUTCH-1931
  • APache CXF dependency
  • Added jaxrs dependency
  • Removed custom providers
  • Added JobResource
  • Added AbstractResource
  • Added JobManager
  • Added http-jetty dependency
  • Added "server" option to start NutchServer
  • Renaming command to startserver
  • Added Apache license
  • Added Apache license
  • Added Apache license
  • Added Apache license
  • Added Apache license
  • Renamed command to start NutchServer in bin/nutch
  • Start on custom port via -port option
  • Added command line option -help
  • Created Nutch tool and implemented in Injector
  • Instantiated JobManager object
  • Added new metadata from REST service
  • Job Enpoint and supporting classes
  • Changed arguments to Map<String, String> for tool
  • Classes for the job endpoint
  • Changed the result arg to Map<String, Object>
  • Added DbResource for running readdb
  • Added support for dump, url options in readdb
  • Corrected the -dir | segments option
  • Added License info
  • Added constructor
  • Removed commented lines
  • Corrected indentation
  • Corrected constructor call
  • Corrected required number of args
  • Corrected args for dir and

File Changes

Patch Links:

—
Reply to this email directly or view it on GitHub
#16.

Lewis

@sujen1412
Copy link
Member Author

sujen1412 commented Apr 1, 2015

Shall I use this - http://svn.apache.org/repos/asf/nutch/branches/2.x/eclipse-codeformat.xml ?

@lewismc
Copy link
Member

lewismc commented Apr 1, 2015

Please thank you very much Sujen. Great work this is going very well.
I'll test out ASAP and make best efforts to drive towards a commit on the
Backport f the REST API. This is grand.

On Tuesday, March 31, 2015, Sujen Shah notifications@github.com wrote:

Shall I use this -
http://svn.apache.org/repos/asf/nutch/branches/2.x/eclipse-codeformat.xml
?

—
Reply to this email directly or view it on GitHub
#16 (comment).

Lewis

@sujen1412
Copy link
Member Author

sujen1412 commented Apr 1, 2015

I am just finishing writing a tutorial on how to run the jobs, on the wiki. The current documentation just gives an example with placeholder arguments.
Will post link as soon as I am done.

@lewismc
Copy link
Member

lewismc commented Apr 1, 2015

Ack good job

On Tuesday, March 31, 2015, Sujen Shah notifications@github.com wrote:

I am just finishing writing a tutorial on how to run the jobs, on the
wiki. The current documentation just gives an example with placeholder
arguments.
Will post link as soon as I am done.

—
Reply to this email directly or view it on GitHub
#16 (comment).

Lewis

@sujen1412
Copy link
Member Author

sujen1412 commented Apr 1, 2015

Here is the link - https://wiki.apache.org/nutch/Nutch_1.X_RESTAPI/RunningJobsTutorial

@sujen1412
Copy link
Member Author

sujen1412 commented Apr 1, 2015

Corrected formatting to conform with Nutch code formatting style

@chrismattmann
Copy link
Contributor

chrismattmann commented Apr 7, 2015

Hey Sujen, this patch doesn't apply cleanly to Nutch there are merge conflicts. Can you please correct them and open up a new PR?

@sujen1412
Copy link
Member Author

sujen1412 commented Apr 7, 2015

Yes will do it.

@chrismattmann
Copy link
Contributor

chrismattmann commented Apr 10, 2015

ping @sujen1412 can you please update the PR?

@sujen1412
Copy link
Member Author

sujen1412 commented Apr 10, 2015

Yes, apologies for the delay will do it by today evening.

sujen1412 added 15 commits April 10, 2015 22:33
@sujen1412
Copy link
Member Author

sujen1412 commented Apr 11, 2015

Updated, and resolved merge conflicts.

@chrismattmann
Copy link
Contributor

chrismattmann commented Apr 18, 2015

@sujen1412 this doesn't apply cleanly can you see my comments on the JIRA?

@sujen1412
Copy link
Member Author

sujen1412 commented Apr 18, 2015 via email

@chrismattmann
Copy link
Contributor

chrismattmann commented Apr 19, 2015

Thanks @sujen1412 let me know when it's ready

@chrismattmann
Copy link
Contributor

chrismattmann commented Apr 21, 2015

@sujen1412 did you complete this?

@asfgit asfgit closed this in 3388a10 Apr 22, 2015
@chrismattmann
Copy link
Contributor

chrismattmann commented Apr 22, 2015

So I pulled out the missing files:

[usc-secure-wireless-061-034:/tmp/nutch-1.10-trunk] mattmann% svn commit -m "Remainder of fix for NUTCH-1973: Job Administration end point for the REST service contributed by Sujen Shah sujen1412@gmail.com"
Adding src/java/org/apache/nutch/service/model/request/JobConfig.java
Adding src/java/org/apache/nutch/util/NutchTool.java
Transmitting file data ..
Committed revision 1675249.
[usc-secure-wireless-061-034:/tmp/nutch-1.10-trunk] mattmann%

lewismc added a commit to lewismc/nutch that referenced this pull request Feb 27, 2023
@lewismc
Merge pull request apache#16 from jbsimmon/NUTCH-2940
cb710bc 
NUTCH 2940 Develop Gradle Core Build for Apache Nutch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sujen1412 @lewismc @chrismattmann