NUTCH-2729 protocol-okhttp: fix marking of truncated content#462
Merged
sebastian-nagel merged 3 commits intoapache:masterfrom Sep 1, 2019
Merged
Conversation
Contributor
sebastian-nagel
commented
Aug 13, 2019
sebastian-nagel
commented
- request one byte more than the configured content limit (http.content.limit) to detect truncations reliably
- add unit tests for marking of truncations, also for gzip Content-Encoding and chunked Transfer-Encoding
sebastian-nagel
force-pushed
the
NUTCH-2729-protocol-okhttp-mark-truncated
branch
from
4782908 to
78da166
Compare
- avoid integer overflow if http.content.limit == -1
sebastian-nagel
force-pushed
the
NUTCH-2729-protocol-okhttp-mark-truncated
branch
from
78da166 to
5c45172
Compare
Contributor
Author
|
Rebased to master and merged with changes to protocol-okhttp related to NUTCH-2927/#460. |
Member
|
+1 LGTM |
- log exception which caused a partial fetch and content is kept as truncated (marked as "disconnect") - add unit test to verify that partial fetches are kept if http.partial.truncated == true
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.