NUTCH-2218 - Update CrawlComplete util with Commons CLI arg parsing #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Switch all argument parsing and checking to commons CLI. - Update input directory processing such that the 'crawldb' folder should no longer be included in the input paths. Now the user simply points to the crawl folder instead of specific crawldb directories.
| Option inDirs = OptionBuilder | ||
| .withArgName("inputDirs") | ||
| .isRequired() | ||
| .withDescription("Comma separated list of crawl directories") |
Member
There was a problem hiding this comment.
This could do with being explicit e.g. providing an example
Member
|
Nice. +1 to this if you can provide an example. |
Member
Author
|
+1 @lewismc I'll see about throwing an example in there when I commit. |
asfgit
pushed a commit
that referenced
this pull request
Feb 18, 2016
git-svn-id: https://svn.apache.org/repos/asf/nutch/trunk@1731103 13f79535-47bb-0310-9956-ffa450edef68
Member
Author
|
Note, closing this manually since I buggered the merge =D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should no longer be included in the input paths. Now the user simply
points to the crawl folder instead of specific crawldb directories.