build: fix libyuv Makefile and adjust cJSON Makefile#1512
Merged
Conversation
Signed-off-by: haopengxiang <haopengxiang@xiaomi.com>
There is no subfolder called "libyuv" in libyuv's folder, check libyuv/libyuv may trigger download libyuv in everytime, hence fixed by check libyuv repo. Signed-off-by: haopengxiang <haopengxiang@xiaomi.com>
xiaoxiang781216
approved these changes
Jan 29, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Impact
With local repo cJson/libyuv exist, no need to download from remote source
Testing
Pass Vela CI