Revert "Don't run preconfig, clean or distclean when it's not necessary."#1632
Closed
xiaoxiang781216 wants to merge 1 commit intoapache:masterfrom
Closed
Revert "Don't run preconfig, clean or distclean when it's not necessary."#1632xiaoxiang781216 wants to merge 1 commit intoapache:masterfrom
xiaoxiang781216 wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
Author
|
@Ouss4 could you take a look? We found that it's hard to trigger clean/distclean with your patch. |
…ry." to ensure all clean/distclean get run. This reverts commit 1dae12b.
Contributor
|
@xiaoxiang781216 I see that both your changes are closed. So does it mean that we do not have the issue, or that you are preparing another solution? |
Contributor
Author
|
I will hack the individual Makefile instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
to ensure all clean/distclean get run.
This reverts commit 1dae12b.
Impact
clean/distclean
Testing
CI