Merged
Conversation
Signed-off-by: yinshengkai <yinshengkai@xiaomi.com>
pkarashchenko
approved these changes
Mar 8, 2023
| /* Process each option */ | ||
|
|
||
| first = true; | ||
| lib_memoutstream(&stream, alloca(sizeof(struct utsname)), |
Contributor
There was a problem hiding this comment.
is it enough to allocate struct utsname in the extreme case? since we add more ' ' and '\n'.
Contributor
Author
There was a problem hiding this comment.
It is adequate, an extra 7 characters are added when using “uname -a”
But utsname->sysname is 21 (SYS_NAMELEN) bytes, only 6 bytes ("NuttX") are actually used
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
one-time output uname，fix "uname -a > /dev/null" output format error
Impact
Testing
sim/nsh