Merged
Conversation
application may use micro-ecc for some ecc operation, which may be faster than tinycrypt, due to assamble code, but both of them have same function defination, cause build error on there case. Signed-off-by: Lingao Meng <menglingao@xiaomi.com>
Contributor
Author
|
@pkarashchenko could you review this simple change? |
pkarashchenko
approved these changes
Aug 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
application may use micro-ecc for some ecc operation, which may be faster than tinycrypt, due to assemble code, but both of them have same function definition, cause build error on there case.
Impact
new option
Testing
internal test