Skip to content

interpreters/duktape: Fix error: variable 'num_stmts' set but not used #2068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pkarashchenko merged 1 commit into from
Sep 17, 2023
Merged

interpreters/duktape: Fix error: variable 'num_stmts' set but not used #2068

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions interpreters/duktape/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ $(DUKTAPE_UNPACK): $(DUKTAPE_TARBALL)
$(Q) mv duktape-$(DUKTAPE_VERSION) $(DUKTAPE_UNPACK)
$(Q) echo "Patching $(DUKTAPE_UNPACK)"
$(Q) patch -p0 < duk_cmdline.patch
$(Q) patch -p0 < not_used.patch

$(DUKTAPE_UNPACK)/.patch: $(DUKTAPE_UNPACK)
$(Q) touch $(DUKTAPE_UNPACK)/.patch
Expand Down
42 changes: 42 additions & 0 deletions interpreters/duktape/not_used.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
From 1ed7f75cf9652b44bc5e1a81552bf4431e10697e Mon Sep 17 00:00:00 2001
From: Xiang Xiao <xiaoxiang@xiaomi.com>
Date: Mon, 11 Sep 2023 18:02:36 +0800
Subject: [PATCH] Fix Error: duktape/src-noline/duktape.c:73222:13: error:
variable 'num_stmts' set but not used [-Werror,-Wunused-but-set-variable]

Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
---
src-input/duk_js_compiler.c | 3 ---
1 file changed, 3 deletions(-)

diff --git duktape/src-input/duk_js_compiler.c duktape/src-input/duk_js_compiler.c
index ecf03eaf..866371b5 100644
--- duktape/src-input/duk_js_compiler.c
+++ duktape/src-input/duk_js_compiler.c
@@ -5567,7 +5567,6 @@ DUK_LOCAL void duk__parse_switch_stmt(duk_compiler_ctx *comp_ctx, duk_ivalue *re
temp_at_loop = DUK__GETTEMP(comp_ctx);

for (;;) {
- duk_int_t num_stmts;
duk_small_uint_t tok;

/* sufficient for keeping temp reg numbers in check */
@@ -5646,7 +5645,6 @@ DUK_LOCAL void duk__parse_switch_stmt(duk_compiler_ctx *comp_ctx, duk_ivalue *re
* test-bug-case-fallthrough.js.
*/

- num_stmts = 0;
if (pc_default == -2) {
pc_default = duk__get_current_pc(comp_ctx);
}
@@ -5665,7 +5663,6 @@ DUK_LOCAL void duk__parse_switch_stmt(duk_compiler_ctx *comp_ctx, duk_ivalue *re
tok == DUK_TOK_RCURLY) {
break;
}
- num_stmts++;
duk__parse_stmt(comp_ctx, res, 0 /*allow_source_elem*/);
}

--
2.34.1