nsh_alias.c: unalias -a command does not work correctly#2095
Merged
Conversation
getopt returns the argument if it is found, so testing against != ERROR is wrong.
pussuw
force-pushed
the
alias_remall_fix
branch
from
f8eac60 to
bf982a0
Compare
xiaoxiang781216
approved these changes
Sep 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getopt returns the argument if it is found, so testing against != ERROR is wrong. Testing against 'a' in this case is correct (no other
arguments are possible)
Impact
Fix trivial bug in alias handling (remove all aliases command)
Testing
unalias -a works