import/mk: Use libm from the export package when defined.#2151
Merged
xiaoxiang781216 merged 1 commit intoapache:masterfrom Oct 25, 2023
Merged
import/mk: Use libm from the export package when defined.#2151xiaoxiang781216 merged 1 commit intoapache:masterfrom
xiaoxiang781216 merged 1 commit intoapache:masterfrom
Conversation
Nuttx exports libm.a when `CONFIG_LIBM` is enabled. Adjust the application import makefile to pick this up when linking.
xiaoxiang781216
approved these changes
Oct 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Nuttx exports libm.a when
CONFIG_LIBMis enabled. Adjust the application import makefile to pick this up when linking.Impact
Applications using
CONFIG_BUILD_KERNELandCONIFG_LIBMcan link correctly when needed.Testing
Before this change, when trying to add
CONFIG_EXAMPLES_CALIB_UDELAYWith this change, the
calib_udelayapplication links as expected.