netutils/netinit: Reduce net monitor delay on platforms without 64 bit time type.#2153
Merged
xiaoxiang781216 merged 1 commit intoapache:masterfrom Oct 25, 2023
Merged
Conversation
g2gps
force-pushed
the
netutils-timeout
branch
from
4b94369 to
63fa618
Compare
xiaoxiang781216
approved these changes
Oct 24, 2023
jerpelea
approved these changes
Oct 24, 2023
Contributor
jerpelea
left a comment
jerpelea
left a comment
There was a problem hiding this comment.
please add a commit message
…t time type. Waiting for an hour can cause the calculated tick count in nxsem_clockwait to overflow due to the default width of sclock_t. Reduce the long wait period on platforms not using 64-bit time.
g2gps
force-pushed
the
netutils-timeout
branch
from
63fa618 to
e9beaeb
Compare
xiaoxiang781216
approved these changes
Oct 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Waiting for an hour can cause the calculated tick count in
nxsem_clockwaitto overflow due to the default width ofsclock_t. Reduce the long wait period on platforms not using 64-bit time.Impact
Timed wait in the network monitor thread now operates as intended.
Testing
Custom hardware, based on litex:arty_a7