-
Notifications
You must be signed in to change notification settings - Fork 687
nshlib: add support for pkill command #2585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
xiaoxiang781216
merged 1 commit into
apache:master
from
michallenc:pkill_implementation
Sep 23, 2024
Merged
nshlib: add support for pkill command #2585
xiaoxiang781216
merged 1 commit into
apache:master
from
michallenc:pkill_implementation
Sep 23, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@michallenc could you rebase your change to the last master, the ci break was fixed. |
Contributor
|
Why not |
acassis
approved these changes
Sep 19, 2024
Contributor
Interesting the differences: https://unix.stackexchange.com/questions/91527/whats-the-difference-between-pkill-and-killall |
ecee9aa to
64976b1
Compare
Contributor
Author
Maybe next :) |
Contributor
Author
|
It seems the CI build failure is caused by me. I will look into it tomorrow. |
This command looks through the currently running processes and kills the those that match the selection criteria. This way system can send signal to processes by name and without knowing the IDs. Example (kill application hello): pkill -15 hello The command can be turned off by NSH_DISABLE_PKILL option and depends on FS_PROCFS. Signed-off-by: Michal Lenc <michallenc@seznam.cz>
64976b1 to
3418623
Compare
xiaoxiang781216
approved these changes
Sep 20, 2024
jerpelea
approved these changes
Sep 20, 2024
xiaoxiang781216
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This command looks through the currently running processes and kills the those that match the selection criteria. This way system can send signal to processes by name and without knowing the IDs. The implementation match the one of
killandpidof.Example (kill application hello):
pkill -15 helloThe command can be turned off by
NSH_DISABLE_PKILLoption and depends onFS_PROCFS.Impact
New command.