kasantest.c: fix the size passed by mm_initialize is incorrect and add CMakeLists.txt #2590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerpelea
requested changes
Sep 20, 2024
Contributor
jerpelea
left a comment
jerpelea
left a comment
There was a problem hiding this comment.
please fill commit messages that explain the change and the reason why it is needed
W-M-R
changed the title
Contributor
|
Also please update Testing description. No means no testing was made. Please provide testing logs before change and after change (proof of fix). |
Signed-off-by: wangmingrong1 <wangmingrong1@xiaomi.com>
Signed-off-by: wangmingrong1 <wangmingrong1@xiaomi.com>
signed-off-by: W-M-R <Mike_0528@163.com>
xiaoxiang781216
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Impact
testing/kasantest.Testing
No