Skip to content

nshlib: fix top command sorting result error#2714

Merged
xiaoxiang781216 merged 1 commit into
apache:masterfrom
Gary-Hobson:nsh-ps
Oct 16, 2024
Merged

nshlib: fix top command sorting result error#2714
xiaoxiang781216 merged 1 commit into
apache:masterfrom
Gary-Hobson:nsh-ps

Conversation

@Gary-Hobson
Copy link
Copy Markdown
Contributor

@Gary-Hobson Gary-Hobson commented Oct 13, 2024

Summary

nshlib: fix top command sorting result erro

Impact

top

Testing

sim

@nuttxpr
Copy link
Copy Markdown

nuttxpr commented Oct 13, 2024

[Experimental Bot, please feedback here]

No, this PR does not meet the NuttX requirements.

Missing Information:

  • Summary:
    • Lacks a description of why the change is necessary. Is it a new feature request? Does it fix a bug?
    • Needs more detail on how the "top" and "watch" commands work. What information do they display? How are they used?
  • Impact:
    • All impact sections are empty. You must address each point (user impact, build impact, hardware impact, etc.) with either "NO" or a "YES" followed by a description.
  • Testing:
    • "sim" is not enough information. Specify the host OS, CPU, compiler, target architecture, board, and configuration.
    • Provide actual testing logs from before and after the change.

To improve this PR:

  1. Expand the Summary: Clearly articulate the purpose and functionality of the new commands.
  2. Complete the Impact Section: Assess and describe the impact of your changes on all aspects mentioned.
  3. Provide Detailed Testing Information: List your testing environment specifics and include relevant logs demonstrating the changes' effects.

Comment thread system/telnetd/Kconfig Outdated
@xiaoxiang781216
Copy link
Copy Markdown
Contributor

@Gary-Hobson please fix ci error:

====================================================================================
Configuration/Tool: same70-xplained/mcuboot-loader,CONFIG_ARM_TOOLCHAIN_GNU_EABI
2024-10-14 16:17:34
------------------------------------------------------------------------------------
  Cleaning...
  Configuring...
  Disabling CONFIG_ARM_TOOLCHAIN_GNU_EABI
  Enabling CONFIG_ARM_TOOLCHAIN_GNU_EABI
  Building NuttX...
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0

  2 1669k    2 36869    0     0  66926      0  0:00:25 --:--:--  0:00:25 66926
100 1669k  100 1669k    0     0  2001k      0 --:--:-- --:--:-- --:--:-- 5772k
arm-none-eabi-ld: /github/workspace/sources/nuttx/nuttx section `.ramfunc' will not fit in region `flash'
arm-none-eabi-ld: region `flash' overflowed by 52 bytes
arm-none-eabi-ld: warning: /github/workspace/sources/nuttx/nuttx has a LOAD segment with RWX permissions
make[1]: *** [Makefile:212: nuttx] Error 1
make: *** [tools/Unix.mk:551: nuttx] Error 2
make: Target 'all' not remade because of errors.
/github/workspace/sources/nuttx/tools/testbuild.sh: line 385: /github/workspace/sources/nuttx/../nuttx/nuttx.manifest: No such file or directory
  Normalize same70-xplained/mcuboot-loader
On branch master
Your branch is up to date with 'origin/master'.

Untracked files:
  (use "git add <file>..." to include in what will be committed)
	boards/arm/samv7/same70-xplained/scripts/flash.ld.tmp

nothing added to commit but untracked files present (use "git add" to track)

@Gary-Hobson
Copy link
Copy Markdown
Contributor Author

@Gary-Hobson please fix ci error:

Enable LTO in the following PR to avoid insufficient flash errors during compilation
apache/nuttx#14287

@Gary-Hobson Gary-Hobson force-pushed the nsh-ps branch 2 times, most recently from 6551ab8 to c47c86b Compare October 16, 2024 05:47
@xiaoxiang781216
Copy link
Copy Markdown
Contributor

@Gary-Hobson please fix the conflict.

qsort expects the return value to be -1,0,1

Signed-off-by: yinshengkai <yinshengkai@xiaomi.com>
@github-actions github-actions Bot added Size: XS and removed Size: L labels Oct 16, 2024
@xiaoxiang781216 xiaoxiang781216 changed the title nsh: Add top command and watch command nshlib: fix top command sorting result error Oct 16, 2024
@xiaoxiang781216 xiaoxiang781216 merged commit 15b081f into apache:master Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants