apps/nshlib/cmd_cd: Modify the logic of cd#2732
Merged
Merged
Conversation
xiaoxiang781216
approved these changes
Oct 15, 2024
W-M-R
force-pushed
the
zhengyu
branch
2 times, most recently
from
b3489a7 to
d3a586f
Compare
Contributor
Author
|
This change involves enabling the variable configuration to support nsh, that is, turning off CONFIG_DISABLE_ENVIRON. Many boards' configs are not enabled, so it is difficult to merge it in. I have to push it back and see how to merge them in. |
Contributor
I will provide a patch fix this problem. |
Contributor
|
Here is the patch: apache/nuttx#14365 |
Contributor
Author
OK，thanks，brother Xiang |
Contributor
|
@W-M-R please repush your patch |
Modify the implementation logic of changing directory. There's an error handling the path incluing "../" or "./" bug examples: nsh> cd proc/self/group nsh> cd ../.. nsh: cd: chdir failed: 2 nsh> pwd /proc/self nsh> ls /proc/self: status cmdline stack group/ nsh> cd ./group nsh: cd: chdir failed: 2 Signed-off-by: zhengyu9 <zhengyu9@xiaomi.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Modify the implementation logic of changing directory. There's an error handling the path incluing "../" or "./"
bug examples:
nsh> cd proc/self/group
nsh> cd ../..
nsh: cd: chdir failed: 2
nsh> pwd
/proc/self
nsh> ls
/proc/self:
status
cmdline
stack
group/
nsh> cd ./group
nsh: cd: chdir failed: 2
Impact
No
Testing
No
depends on apache/nuttx#14365