zlib:Support using Kconfig to control memory usage in zlib#2734
Merged
Conversation
Signed-off-by: anjiahao <anjiahao@xiaomi.com>
|
[Experimental Bot, please feedback here] No, this PR does not meet the NuttX requirements. Here's why and how to improve it: Missing Information
Example of an Improved PR Description ## Summary
This PR introduces Kconfig options to control zlib's memory usage, allowing users to tailor its footprint for memory-constrained systems. Specifically, it adds options for:
* Configuring the size of zlib's internal buffers.
* Enabling/disabling memory allocation strategies that trade off compression ratio for reduced memory consumption.
This change is motivated by [link to relevant NuttX issue, if any].
## Impact
* **Is new feature added?** YES - Fine-grained control over zlib's memory usage.
* **Impact on user?** YES - Users can now configure zlib's memory usage via Kconfig. Documentation will be updated to describe the new options.
* **Impact on build?** NO
* **Impact on hardware?** NO
* **Impact on documentation?** YES - Documentation will be updated to describe the new Kconfig options and their impact on memory usage and compression performance.
* **Impact on security?** NO
* **Impact on compatibility?** NO
* **Anything else to consider?** N/A
## Testing
I confirm that changes are verified on the following setup:
* **Build Host:** Ubuntu 20.04, GCC 9.4.0
* **Target:** QEMU VersatilePB (ARM), `boards/arm/armv7-a/sim/configs/sim_smp.h`
**Testing logs before change:**
<relevant snippet showing zlib's memory usage without the Kconfig options> <relevant snippet showing zlib's memory usage with the new Kconfig options enabled> By providing clear and comprehensive information, you make it easier for reviewers to understand and assess your PR. |
xiaoxiang781216
approved these changes
Oct 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
zlib:Support using Kconfig to control memory usage in zlib
Impact
zlib
Testing
qmeu with zlib