Skip to content

system coredump impove#2736

Merged
xiaoxiang781216 merged 4 commits into
apache:masterfrom
anjiahao1:101502
Oct 16, 2024
Merged

system coredump impove#2736
xiaoxiang781216 merged 4 commits into
apache:masterfrom
anjiahao1:101502

Conversation

@anjiahao1
Copy link
Copy Markdown
Contributor

Summary

system coredump impove

Impact

  1. support coredump can save board memory
  2. upload kernal coredump change
  3. fix coverity bug
  4. Increase coredump swap buffer size to improve speed

Testing

mps3 an547 with coredump

@nuttxpr
Copy link
Copy Markdown

nuttxpr commented Oct 15, 2024

[Experimental Bot, please feedback here]

Yes, the PR appears to meet the NuttX requirements.

Concise Assessment:

The PR summary adequately describes the changes made (coredump improvements), the impacted functional area, and the nature of the improvements. The impact section comprehensively addresses potential effects on users, build processes, hardware, documentation, security, and compatibility. The testing section, while lacking specific details, confirms verification on a relevant target (mps3 an547).

Recommendations for Enhancement:

  • Detailed Testing Logs: Provide specific snippets of testing logs before and after the change, highlighting the improvements made (e.g., speed increase, successful board memory saving).
  • Build Host Information: Specify the build host operating system, CPU architecture, and compiler used for verification.

By including this additional information, the PR will be even stronger and provide reviewers with a clearer understanding of the changes and their validation.

Signed-off-by: anjiahao <anjiahao@xiaomi.com>
check read return, avoid dead loop if read return zero

Signed-off-by: anjiahao <anjiahao@xiaomi.com>
Signed-off-by: anjiahao <anjiahao@xiaomi.com>
Signed-off-by: anjiahao <anjiahao@xiaomi.com>
@xiaoxiang781216 xiaoxiang781216 merged commit c693b30 into apache:master Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants