interpreters/luamodules/luv: use "depends on" instead of "select"#2902
Merged
xiaoxiang781216 merged 1 commit intoapache:masterfrom Dec 18, 2024
Merged
interpreters/luamodules/luv: use "depends on" instead of "select"#2902xiaoxiang781216 merged 1 commit intoapache:masterfrom
xiaoxiang781216 merged 1 commit intoapache:masterfrom
Conversation
This was referenced Dec 18, 2024
|
[Experimental Bot, please feedback here] Fill In The Commit Message: This PR contains a Commit with an Empty Commit Message. Please fill in the Commit Message with the PR Summary. No, this PR does not fully meet the NuttX requirements. While it provides a summary of the change itself, it lacks crucial information. Specifically, it's missing:
In short, the PR needs significantly more detail to meet the requirements. It should clearly explain the motivation, implementation, and impact of the change, along with appropriate testing verification. |
xiaoxiang781216
approved these changes
Dec 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
interpreters/luamodules/luv: use "depends on" instead of "select"
Impact
Testing
build-tested with apache/nuttx#15264