fs_stat_test: fix fs date case not strict enough #3226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use utc diff should prefer and more strict. Signed-off-by: buxiasen <buxiasen@xiaomi.com>
xiaoxiang781216
approved these changes
Nov 30, 2025
jerpelea
approved these changes
Dec 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
use utc diff should prefer and more strict.
Impact
Before fix, the case using assert_int_equal(min1, min2); These should not strict enough, for example if the case start runs with 09:59:59 etc, and with corner case or even if the host performance is not strong enough, will case easily break.
After fix, we just make sure the case is within positive or negative within 30s. should be equal for most time with old case. And still able to catch if the fs time usage break.
Testing
CI-test, sim hostfs test.