add -f for umount #3240
Merged
add -f for umount #3240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zfeather914
force-pushed
the
your-topic
branch
from
d107e31 to
927b21a
Compare
xiaoxiang781216
approved these changes
Dec 9, 2025
adds support for the -f (force) option to the NSH umount command Signed-off-by: zhengyu16 <zhengyu16@xiaomi.com>
Zfeather914
force-pushed
the
your-topic
branch
from
927b21a to
8d6d495
Compare
cederom
requested changes
Dec 9, 2025
Contributor
cederom
left a comment
cederom
left a comment
There was a problem hiding this comment.
Thank you @Zfeather914 very nice feature!
- Can you please provide simple update to documentation too (https://nuttx.apache.org/docs/latest/applications/nsh/commands.html#umount-unmount-a-file-system)?
- Please remember to provide test logs, even simple ones :-)
Contributor
but @cederom could you remove the "requested change" mark since @Zfeather914 need update nuttx repo not nuttx-apps? |
cederom
approved these changes
Dec 10, 2025
Contributor
cederom
left a comment
cederom
left a comment
There was a problem hiding this comment.
Thank you @Zfeather914 :-)
Contributor
@Zfeather914 please create a pr on nuttx repo to update the document. |
Zfeather914
added a commit
to Zfeather914/nuttx
that referenced
this pull request
Dec 11, 2025
Reference: apache/nuttx-apps#3240 Signed-off-by: zhengyu16 <zhengyu16@xiaomi.com>
linguini1
pushed a commit
to apache/nuttx
that referenced
this pull request
Dec 11, 2025
Reference: apache/nuttx-apps#3240 Signed-off-by: zhengyu16 <zhengyu16@xiaomi.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This Pull Request adds support for the -f (force) option to the NSH
umount command.
The enhancement allows users to perform forced unmount operations
by passing the MNT_FORCE flag through the new umount2() backend.
Impact
Users can now force an unmount using:
umount -f