sh cle_fd returns EOF if there is no data be read. #3242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modify swtichboot -> switchboot Signed-off-by: yangsong8 <yangsong8@xiaomi.com>
xiaoxiang781216
previously approved these changes
Dec 9, 2025
Contributor
|
@yangsong8-a1 fix: |
linguini1
previously approved these changes
Dec 9, 2025
Contributor
linguini1
left a comment
linguini1
left a comment
There was a problem hiding this comment.
Should be -EOF or is it expected to return a positive value everywhere?
Contributor
EOF is already negative number(-1). |
simbit18
previously approved these changes
Dec 9, 2025
If enable CONFIG NSH_CLE. When sh reads data and detects that nread is 0, return EOF and exit. Signed-off-by: yangsong8 <yangsong8@xiaomi.com>
yangsong8-a1
dismissed stale reviews from simbit18, linguini1, and xiaoxiang781216
via
d573815
simbit18
approved these changes
Dec 9, 2025
xiaoxiang781216
approved these changes
Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fix switchboot command spelling error.
sh cle_fd returns EOF if there is no data be read.
Impact
when there is no data to be read. sh cle_fd returns EOF but not -EIO
Testing
When CONFIG_NSH_CLE is enabled, after the adb shell service is destroyed, sh detects nread as 0 when reading data, but instead of returning EOF, it returns -EIO, thus preventing sh from exiting.
target： sim and xiaomi product