Skip to content

Conversation

@zkkkk12
Copy link

@zkkkk12 zkkkk12 commented Dec 29, 2025

Note: Please adhere to Contributing Guidelines.

Summary

Ensure it is not blocked by the iperf thread, preventing iperf from completing

Impact

This ensures that iperf executes correctly.

Testing

The bandwidth can be measured normally using iperf, which comes with NuttX.
On the device: iperf -s -i 1 -t 10
On the PC: iperf -c 10.0.0.2 -i 1 -t 10
before:

core1> iperf -s -i 1 -t 10
     IP: 10.0.0.2
 mode=tcp-server sip=10.0.0.2:5001,dip=0.0.0.0:5001, interval=1, time=10
accept: 10.0.0.11:50038
           Interval         Transfer         Bandwidth

Printing gets stuck at this point.
Improved:

core1> iperf -s -i 1 -t 10
     IP: 10.0.0.2

 mode=tcp-server sip=10.0.0.2:5001,dip=0.0.0.0:5001, interval=1, time=10
accept: 10.0.0.11:50038

           Interval         Transfer         Bandwidth

   0.00-   1.00 sec    8713788 Bytes   69.69 Mbits/sec
   1.00-   2.00 sec    8717184 Bytes   69.72 Mbits/sec
   2.00-   3.00 sec    8673408 Bytes   69.37 Mbits/sec
   3.00-   4.00 sec    8683776 Bytes   69.43 Mbits/sec
   4.00-   5.00 sec    8688384 Bytes   69.47 Mbits/sec
   5.00-   6.00 sec    8681472 Bytes   69.43 Mbits/sec
iperf exit

Copy link
Contributor

@cederom cederom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @zkkkk12, this fix is trivial, but we cannot accept PRs with quality below requirements.

Please read carefully https://github.com/apache/nuttx/blob/master/CONTRIBUTING.md and update the PR description.

Please provide plaintext logs, provided image is unreadable and bigger than several lines of text anyways.

@zkkkk12
Copy link
Author

zkkkk12 commented Dec 29, 2025

Thank you @zkkkk12, this fix is trivial, but we cannot accept PRs with quality below requirements.

Please read carefully https://github.com/apache/nuttx/blob/master/CONTRIBUTING.md and update the PR description.

Please provide plaintext logs, provided image is unreadable and bigger than several lines of text anyways.

Thank you very much for your comments. I have made the necessary corrections as required.

Copy link
Contributor

@cederom cederom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @zkkkk12 great work! :-)

@zkkkk12 zkkkk12 closed this Dec 29, 2025
@zkkkk12 zkkkk12 reopened this Dec 29, 2025
Copy link
Contributor

@linguini1 linguini1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the commit message to start with iperf: , so that there is a space after the colon.

Also try to shorten the commit title, it is too long so the check is failing.

@zkkkk12 zkkkk12 closed this Dec 30, 2025
@zkkkk12 zkkkk12 reopened this Dec 30, 2025
@zkkkk12 zkkkk12 changed the title Iperf:Increase the priority of the report thread to ensure it is not blocked by the iperf thread, preventing iperf from completing Iperf: Increase the priority of the report thread Dec 30, 2025
@zkkkk12 zkkkk12 closed this Dec 30, 2025
@zkkkk12 zkkkk12 reopened this Dec 30, 2025
@zkkkk12 zkkkk12 closed this Dec 30, 2025
@zkkkk12 zkkkk12 reopened this Dec 30, 2025
@zkkkk12 zkkkk12 changed the title Iperf: Increase the priority of the report thread iperf: Increase the priority of the report thread Dec 30, 2025
@zkkkk12 zkkkk12 closed this Dec 30, 2025
@zkkkk12 zkkkk12 reopened this Dec 30, 2025
ensure it is not blocked by the iperf thread, preventing iperf from completing

Signed-off-by: zhangkai25 <zhangkai25@xiaomi.com>
@xiaoxiang781216 xiaoxiang781216 merged commit 710aef6 into apache:master Dec 30, 2025
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants