-
Notifications
You must be signed in to change notification settings - Fork 659
iperf: Increase the priority of the report thread #3287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cederom
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @zkkkk12, this fix is trivial, but we cannot accept PRs with quality below requirements.
Please read carefully https://github.com/apache/nuttx/blob/master/CONTRIBUTING.md and update the PR description.
Please provide plaintext logs, provided image is unreadable and bigger than several lines of text anyways.
Thank you very much for your comments. I have made the necessary corrections as required. |
cederom
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @zkkkk12 great work! :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the commit message to start with iperf: , so that there is a space after the colon.
Also try to shorten the commit title, it is too long so the check is failing.
ensure it is not blocked by the iperf thread, preventing iperf from completing Signed-off-by: zhangkai25 <zhangkai25@xiaomi.com>
Note: Please adhere to Contributing Guidelines.
Summary
Ensure it is not blocked by the iperf thread, preventing iperf from completing
Impact
This ensures that iperf executes correctly.
Testing
The bandwidth can be measured normally using iperf, which comes with NuttX.
On the device:
iperf -s -i 1 -t 10On the PC:
iperf -c 10.0.0.2 -i 1 -t 10before:
Printing gets stuck at this point.
Improved: