modbus: move freemodbus to a separate directory#3454
Merged
jerpelea merged 1 commit intoapache:masterfrom Apr 14, 2026
Merged
Conversation
raiden00pl
force-pushed
the
modbus_split
branch
from
3d9fc20 to
2a66406
Compare
move freemodbus to modbus/freemodbus so it is possible to add other modbus implementations Signed-off-by: raiden00pl <raiden00@railab.me>
cederom
approved these changes
Apr 13, 2026
Contributor
cederom
left a comment
cederom
left a comment
There was a problem hiding this comment.
Looks good, thanks @raiden00pl, I will be playing with ModBus in a few days :-)
cederom
requested review from
acassis,
jerpelea,
linguini1,
michallenc and
simbit18
linguini1
approved these changes
Apr 13, 2026
jerpelea
approved these changes
Apr 14, 2026
Contributor
|
@raiden00pl nice fix! BTW, maybe we should move modbus to inside Industry/ because it is a protocol and at root of apps/ normally are categories of applications |
Member
Author
|
@acassis I agree that this should be in industry/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
move freemodbus implementation to modbus/freemodbus so it is possible to add other modbus implementations
Impact
there should be no impact, just moving freemodbus to another location.
Testing
compilation tested with:
no functional changes, so nothing else was tested