fix: the nuttx shell (nsh) has no authentication mec... in Kconfig#3486
Closed
orbisai0security wants to merge 1 commit into
Closed
fix: the nuttx shell (nsh) has no authentication mec... in Kconfig#3486orbisai0security wants to merge 1 commit into
orbisai0security wants to merge 1 commit into
Conversation
Automated security fix generated by OrbisAI Security
jerpelea
approved these changes
May 18, 2026
raiden00pl
requested changes
May 18, 2026
Member
raiden00pl
left a comment
raiden00pl
left a comment
There was a problem hiding this comment.
these AI bots have no idea what they are doing. This is a feature, not a bug
Contributor
I see no harm on having authentication on by default |
Member
|
@jerpelea 1. Increases flash usage for all targets. 2. breaks automated tests. 3. Makes life harder for devs who have to enter passwords each time to play with devboard :) |
tmedicci
requested changes
May 18, 2026
Contributor
tmedicci
left a comment
tmedicci
left a comment
There was a problem hiding this comment.
I'm against turning this config on by default too...
Contributor
|
+1 not to enable by default too, it can be easily enabled when needed, and we had password management update recenlty :-) |
Contributor
|
Can we please block these bot PRs? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix critical severity security issue in
nshlib/Kconfig.Vulnerability
V-009nshlib/Kconfig:33Description: The NuttX Shell (NSH) has no authentication mechanism enabled. CONFIG_NSH_LOGIN is not confirmed as active, meaning any entity with physical access to the serial console or network access (if NSH is exposed via telnet) can interact with the full shell immediately without providing any credentials. This is the highest-risk finding in the assessment because it eliminates all access control for the most powerful interface on the device.
Changes
nshlib/KconfigVerification