-
Notifications
You must be signed in to change notification settings - Fork 1.5k
mkdeps doesn't handle shell special characters #1100
Copy link
Copy link
Closed
Description
mkdeps uses system() thus a shell to execute cc.
it doesn't work if you have something like
CFLAGS += -DMBEDTLS_USER_CONFIG_FILE="<mbedtls/user_config.h>"
because the shell interprets "<" as a redirect.
to fix it, we should do either
- make it shell-quote arguments
- or, stop using system()
some platforms provide easy ways to do the former.
eg. https://netbsd.gw.com/cgi-bin/man-cgi?shquote++NetBSD-current
but unfortunately none of them seems available widely.
i guess the latter approach is more common.
eg. https://github.com/NetBSD/src/blob/4464250282160188d09bef1ac67ec944b9a8a828/usr.bin/mkdep/mkdep.c#L137-L154
but i might be a burden for windows. (i don't know)
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels