Fix error: '%s' directive output may be truncated#10160
Closed
xiaoxiang781216 wants to merge 1 commit intoapache:masterfrom
Closed
Fix error: '%s' directive output may be truncated#10160xiaoxiang781216 wants to merge 1 commit intoapache:masterfrom
xiaoxiang781216 wants to merge 1 commit intoapache:masterfrom
Conversation
writing up to 31 bytes into a region of size 27 [-Werror=format-truncation=] Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
| FAR const char *pinname) | ||
| { | ||
| char devname[32]; | ||
| char devname[64]; |
Contributor
There was a problem hiding this comment.
I do not see how this should help. Maybe snprintf(devname, sizeof(devname) - 5, "/dev/%s", pinname); instead or snprintf(devname, sizeof(devname) - sizeof("/dev/") - 1, "/dev/%s", pinname);?
Contributor
Author
There was a problem hiding this comment.
You are right, the problem is fixed here: #8658. Let's close this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
writing up to 31 bytes into a region of size 27 [-Werror=format-truncation=]
Impact
Testing
ci