Skip to content

arm64/qemu: fix build error.#10559

Closed
wming-github wants to merge 1 commit intoapache:masterfrom
wming-github:qemu-arm64
Closed

arm64/qemu: fix build error.#10559
wming-github wants to merge 1 commit intoapache:masterfrom
wming-github:qemu-arm64

Conversation

@wming-github
Copy link
Copy Markdown

Summary

Fix build error.
LD: nuttx
aarch64-none-elf-ld: /home/cuiziwei/vela/happy/nuttx/staging/libarch.a(arm64_initialize.o): in function up_initialize': /home/cuiziwei/vela/happy/nuttx/arch/arm64/src/common/arm64_initialize.c:208: undefined reference to arm64_netinitialize'
/home/cuiziwei/vela/happy/nuttx/arch/arm64/src/common/arm64_initialize.c:208:(.text.up_initialize+0x18): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `arm64_netinitialize'
make[1]: *** [Makefile:166: nuttx] Error 1
make: *** [tools/Unix.mk:520: nuttx] Error 2
make: Leaving directory '/home/cuiziwei/vela/happy/nuttx'
Error: ############# build /home/cuiziwei/vela/happy/vendor/qemu/boards/vela/configs/armv8a fail ##############

Impact

Testing

LD: nuttx
aarch64-none-elf-ld: /home/cuiziwei/vela/happy/nuttx/staging/libarch.a(arm64_initialize.o): in function `up_initialize':
/home/cuiziwei/vela/happy/nuttx/arch/arm64/src/common/arm64_initialize.c:208: undefined reference to `arm64_netinitialize'
/home/cuiziwei/vela/happy/nuttx/arch/arm64/src/common/arm64_initialize.c:208:(.text.up_initialize+0x18): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `arm64_netinitialize'
make[1]: *** [Makefile:166: nuttx] Error 1
make: *** [tools/Unix.mk:520: nuttx] Error 2
make: Leaving directory '/home/cuiziwei/vela/happy/nuttx'
Error: ############# build /home/cuiziwei/vela/happy/vendor/qemu/boards/vela/configs/armv8a fail ##############

Signed-off-by: cuiziwei <cuiziwei@xiaomi.com>
@pkarashchenko
Copy link
Copy Markdown
Contributor

Maybe just add

#if defined(CONFIG_NET) && !defined(CONFIG_NETDEV_LATEINIT)
void arm64_netinitialize(void)
{
  /* TODO: Support net initialize */
}
#endif

to arch/arm64/src/qemu/qemu_boot.c like other arch's under arm64? We can go with a separate file, but let's add !defined(CONFIG_NETDEV_LATEINIT) guard

@xiaoxiang781216
Copy link
Copy Markdown
Contributor

Don't need since DRIVERS_VIRTIO_NET select NETDEV_LATEINIT automatically, let's close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants