libm/libmcs: Fix clang build libmcs warning#10663
Merged
xiaoxiang781216 merged 1 commit intoapache:masterfrom Sep 18, 2023
Merged
libm/libmcs: Fix clang build libmcs warning#10663xiaoxiang781216 merged 1 commit intoapache:masterfrom
xiaoxiang781216 merged 1 commit intoapache:masterfrom
Conversation
siryang2006
force-pushed
the
your-topic
branch
from
718a8cf to
cffc8a6
Compare
pkarashchenko
approved these changes
Sep 18, 2023
VELAPLATFO-15795 Fix warnings: 1 warning generated. CC: libmcs/libmcs/libm/mathd/lrintd.c libmcs/libmcs/libm/mathd/lrintd.c:141:20: warning: implicit conversion from 'unsigned long long' to 'long' changes value from 9223372036854775808 to 0 [-Wconstant-conversion] return __MIN_LONG; ~~~~~~ ^~~~~~~~~~ /mnt/yang/vela_keystore_sim/nuttx/libs/libm/libmcs/libmcs/libm/include/internal_config.h:50:24: note: expanded from macro '__MIN_LONG' #define __MIN_LONG 0x8000000000000000L ^~~~~~~~~~~~~~~~~~~ libmcs/libmcs/libm/mathd/lrintd.c:144:20: warning: implicit conversion from 'long long' to 'long' changes value from 9223372036854775807 to -1 [-Wconstant-conversion] return __MAX_LONG; ~~~~~~ ^~~~~~~~~~ /mnt/yang/vela_keystore_sim/nuttx/libs/libm/libmcs/libmcs/libm/include/internal_config.h:49:24: note: expanded from macro '__MAX_LONG' #define __MAX_LONG 0x7FFFFFFFFFFFFFFFL ^~~~~~~~~~~~~~~~~~~ 2 warnings generated. CC: libmcs/libmcs/libm/mathd/lroundd.c libmcs/libmcs/libm/mathd/lroundd.c:123:20: warning: implicit conversion from 'unsigned long long' to 'long' changes value from 9223372036854775808 to 0 [-Wconstant-conversion] return __MIN_LONG; ~~~~~~ ^~~~~~~~~~ /mnt/yang/vela_keystore_sim/nuttx/libs/libm/libmcs/libmcs/libm/include/internal_config.h:50:24: note: expanded from macro '__MIN_LONG' #define __MIN_LONG 0x8000000000000000L ^~~~~~~~~~~~~~~~~~~ libmcs/libmcs/libm/mathd/lroundd.c:126:20: warning: implicit conversion from 'long long' to 'long' changes value from 9223372036854775807 to -1 [-Wconstant-conversion] return __MAX_LONG; ~~~~~~ ^~~~~~~~~~ /mnt/yang/vela_keystore_sim/nuttx/libs/libm/libmcs/libmcs/libm/include/internal_config.h:49:24: note: expanded from macro '__MAX_LONG' #define __MAX_LONG 0x7FFFFFFFFFFFFFFFL ^~~~~~~~~~~~~~~~~~~ 2 warnings generated. CC: libmcs/libmcs/libm/mathf/lrintf.c libmcs/libmcs/libm/mathf/lrintf.c:67:20: warning: implicit conversion from 'unsigned long long' to 'long' changes value from 9223372036854775808 to 0 [-Wconstant-conversion] return __MIN_LONG; ~~~~~~ ^~~~~~~~~~ /mnt/yang/vela_keystore_sim/nuttx/libs/libm/libmcs/libmcs/libm/include/internal_config.h:50:24: note: expanded from macro '__MIN_LONG' #define __MIN_LONG 0x8000000000000000L ^~~~~~~~~~~~~~~~~~~ libmcs/libmcs/libm/mathf/lrintf.c:70:20: warning: implicit conversion from 'long long' to 'long' changes value from 9223372036854775807 to -1 [-Wconstant-conversion] return __MAX_LONG; ~~~~~~ ^~~~~~~~~~ /mnt/yang/vela_keystore_sim/nuttx/libs/libm/libmcs/libmcs/libm/include/internal_config.h:49:24: note: expanded from macro '__MAX_LONG' #define __MAX_LONG 0x7FFFFFFFFFFFFFFFL ^~~~~~~~~~~~~~~~~~~ 2 warnings generated. CC: libmcs/libmcs/libm/mathf/lroundf.c libmcs/libmcs/libm/mathf/lroundf.c:32:20: warning: implicit conversion from 'unsigned long long' to 'long' changes value from 9223372036854775808 to 0 [-Wconstant-conversion] return __MIN_LONG; ~~~~~~ ^~~~~~~~~~ /mnt/yang/vela_keystore_sim/nuttx/libs/libm/libmcs/libmcs/libm/include/internal_config.h:50:24: note: expanded from macro '__MIN_LONG' #define __MIN_LONG 0x8000000000000000L ^~~~~~~~~~~~~~~~~~~ libmcs/libmcs/libm/mathf/lroundf.c:34:20: warning: implicit conversion from 'long long' to 'long' changes value from 9223372036854775807 to -1 [-Wconstant-conversion] return __MAX_LONG; ~~~~~~ ^~~~~~~~~~ /mnt/yang/vela_keystore_sim/nuttx/libs/libm/libmcs/libmcs/libm/include/internal_config.h:49:24: note: expanded from macro '__MAX_LONG' #define __MAX_LONG 0x7FFFFFFFFFFFFFFFL Signed-off-by: yanghuatao <yanghuatao@xiaomi.com>
siryang2006
force-pushed
the
your-topic
branch
from
cffc8a6 to
321a443
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix warnings:
Impact
minor
Testing
ci