stm32_eth: Fix excessively long critical section in ifdown handler#10815
Merged
xiaoxiang781216 merged 1 commit intoSep 26, 2023
Merged
Conversation
stm32_ifdown() holds critical section when calling stm32_ethreset(). That function used to call up_mdelay(10) while waiting for the ethernet peripheral reset to complete. This resulted in excessively long critical section time with interrupts disabled. The actual expected delay is a few clock ticks of the 50 MHz clock domain. This commit changes polling interval to 1us and maximum to 10us.
xiaoxiang781216
approved these changes
Sep 26, 2023
xiaoxiang781216
approved these changes
Sep 26, 2023
jerpelea
approved these changes
Sep 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
stm32_ifdown() holds critical section when calling stm32_ethreset().
That function used to call up_mdelay(10) while waiting for the ethernet peripheral reset to complete.
This resulted in excessively long critical section time with interrupts disabled.
The actual expected delay is a few clock ticks of the 50 MHz clock domain.
This commit changes polling interval to 1us and maximum to 10us.
Impact
Reduces critical section time. Shouldn't cause functional changes.
If for some reason (stopped clock?) the ethernet peripheral reset doesn't complete, log message
ERROR: stm32_ethreset failed (timeout), still assuming it's going down.will be printed after 10 us, instead of the previous 100 ms wait.Testing
Tested on custom STM32F417 board with KSZ8081RNA PHY.