boards/fvp-armv8r: Update defconfig after running refresh.sh #11440
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaoxiang781216
approved these changes
Dec 22, 2023
Contributor
|
it's strange that ci doesn't catch this problem. |
jerpelea
approved these changes
Dec 22, 2023
Contributor
jerpelea
left a comment
jerpelea
left a comment
There was a problem hiding this comment.
can you please add a commit message
raiden00pl
reviewed
Dec 22, 2023
| # CONFIG_NSH_ARGCAT is not set | ||
| # CONFIG_NSH_CMDOPT_HEXDUMP is not set | ||
| CONFIG_ARCH="arm" | ||
| CONFIG_ARCH_BOARD="stm32f4discovery" |
Contributor
Author
There was a problem hiding this comment.
wow! Good finding!
I just run ./tools/refresh.sh and it created these modifications!
Contributor
Author
Could you please run: And see if same issue file will be updated? |
Contributor
Author
|
I will close this PR, but first, please guys, run the same build script to confirm it is failing. I don't remember if I ran make distclean before running it, probably it was configured to stm32f4discovery. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update defconfig after running refresh.sh
Impact
Only fvp-armv8r
Testing
N/A