build.yml: Updated the workflow to use version v4 of the actions/upload-artifact and actions/download-artifact.#12746
Merged
xiaoxiang781216 merged 1 commit intoapache:masterfrom Jul 22, 2024
Conversation
…d-artifact and actions/download-artifact.
xiaoxiang781216
approved these changes
Jul 22, 2024
acassis
approved these changes
Jul 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Starting November 30, 2024, GitHub Actions customers will no longer be able to use v3 of actions/upload-artifact or actions/download-artifact.
https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/
Breaking change using V4
Due to how Artifacts are created in this new version, it is no longer possible to upload to the same named Artifact multiple times.
https://github.com/actions/upload-artifact?tab=readme-ov-file#breaking-changes
Currently in our workflow each type of runner processing work (Linux, Mac and Windows) in the artifacts generates a single file with all jobs.
Solution present in this PR
modified
https://github.com/apache/nuttx/blob/17aec1328a6c993d4cb8009fb2ac1893103ba936/.github/workflows/build.yml#L171C18-L171C27
name: linux-builds -> name: linux-${{matrix.boards}}-builds
So, in the artifacts produced at runtime, instead of having one linux-builds file, we will have x files as many as jobs.
linux example:
linux-arm-01-builds
linux-arm-02-builds
etc.
Of course, the same is true for mac and msys2.
This PR removes the following warning annotations:
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/upload-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/download-artifact@v3, actions/upload-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Impact
Improvements
Uploads are significantly faster, upwards of 90% improvement in worst case scenarios.
https://github.com/actions/upload-artifact?tab=readme-ov-file#improvements
Testing
CI