net/tcp: Fix TCP keepalive time unit misuse problem

[zs39]

Summary

The conn->keeptimer units is decisecond，but its unit is treated as half-second in the tcp_timer & tcp_get_timeout function.
This question was asked here:
#13493

Impact

Only affects the TCP keepalive mechanism.

Testing

Local packet capture verification.

[nuttxpr]

[Experimental Bot, please feedback here]

This Pull Request appears to meet the basic NuttX requirements for clarity and content.

Here's a breakdown based on the provided information:

Strengths:

• Clear Summary: The summary effectively explains the problem (unit mismatch in keepalive timer), the affected code (tcp_timer & tcp_get_timeout), and provides a link to the related issue.
• Concise Impact: The impact section is brief but directly addresses the affected area (TCP keepalive). More details on the specific effects might be beneficial.
• Testing Evidence: The PR includes a section for testing logs, demonstrating an effort to verify the changes.

Areas for Potential Improvement:

• Expand on Impact: While mentioning the affected area is good, consider adding:
  • Specific consequences of the bug: What were the real-world effects of the unit mismatch?
  • How the fix addresses these: How does the PR ensure the keepalive mechanism now works as intended?
• Detailed Testing:
  • Provide context for the logs: What do the logs represent? What tools were used to capture them?
  • Highlight key differences: Instead of just raw logs, point out the specific changes observed before and after the fix.
• Consider Additional Impact Fields:
  • Impact on compatibility: While you state it only affects keepalive, double-check if any compatibility concerns might arise from the change.
  • Impact on documentation: If the keepalive mechanism's behavior was previously undocumented or incorrectly documented, mention the need for updates.

Overall: The PR presents the necessary information clearly. Enhancing the testing section and providing slightly more detail on the impact would further strengthen the submission.

[acassis]

Please include commit message with a quick/small overview of the issue/fix.

[zs39]

Please include commit message with a quick/small overview of the issue/fix.

Done