Skip to content

ci/platforms/darwin.sh: switch Wget to cURL tool#13642

Merged
acassis merged 1 commit intoapache:masterfrom
simbit18:simbit18-mac_platform
Sep 26, 2024
Merged

ci/platforms/darwin.sh: switch Wget to cURL tool#13642
acassis merged 1 commit intoapache:masterfrom
simbit18:simbit18-mac_platform

Conversation

@simbit18
Copy link
Copy Markdown
Contributor

Summary

Switch wget to cURL tool for:

arm_gcc_toolchain()
arm64_gcc_toolchain()
gperf()
riscv_gcc_toolchain()
sparc_gcc_toolchain()
xtensa_esp32_gcc_toolchain()
wasi_sdk()

Used git clone --depth 1 a shallow clone with a history truncated to reduce the clone size for:

kconfig_frontends()

added ninja installation

Impact

Impact on user: No changes to user-facing functionality
Impact on build: Build process remains the same

Testing

CI
my repository

Switch wget to cURL tool for:

arm_gcc_toolchain()
arm64_gcc_toolchain()
gperf()
riscv_gcc_toolchain()
sparc_gcc_toolchain()
xtensa_esp32_gcc_toolchain()
wasi_sdk()

Used git clone --depth 1 a shallow clone with a history truncated to reduce the clone size for:

kconfig_frontends()

added ninja installation
@github-actions github-actions bot added Area: Tooling Area: CI Size: S The size of the change in this PR is small labels Sep 26, 2024
@nuttxpr
Copy link
Copy Markdown

nuttxpr commented Sep 26, 2024

[Experimental Bot, please feedback here]

This PR appears to mostly meet the NuttX requirements, but could use some improvements:

Strengths:

  • Summary: Provides a clear overview of the changes made.
  • Impact: Addresses all the points, even if briefly.
  • Testing: Links to CI runs, demonstrating testing effort.

Areas for Improvement:

  • Summary:
    • Why: Briefly explain the reasoning behind switching to cURL and using shallow clones. What benefits do these changes bring (e.g., speed, reliability, size)?
  • Testing:
    • Specificity: Instead of just "CI", specify the architectures and boards tested.
    • Logs: While linking to CI is good, consider including snippets of relevant log output demonstrating the changes' effects. This provides more immediate context within the PR.
  • Impact:
    • While "NO" is fine for most, elaborate slightly on any "YES" answers, even if it seems obvious. For example, "Impact on build: YES - Ninja is now required".

By addressing these points, you'll make the PR easier to review and merge.

@acassis acassis merged commit 2fbe02a into apache:master Sep 26, 2024
@simbit18 simbit18 deleted the simbit18-mac_platform branch September 26, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: CI Area: Tooling Size: S The size of the change in this PR is small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants