Skip to content

[bt_uart.c] fix bug:cant receive data#14311

Closed
W-M-R wants to merge 1 commit into
apache:masterfrom
W-M-R:bt
Closed

[bt_uart.c] fix bug:cant receive data#14311
W-M-R wants to merge 1 commit into
apache:masterfrom
W-M-R:bt

Conversation

@W-M-R
Copy link
Copy Markdown
Contributor

@W-M-R W-M-R commented Oct 15, 2024

Summary

rootcause: in btuart_rxwork, read data in blocking mode and btuart_read do three times, maybe remote send some packets one time,so it wont read the sencond packets.

Impact

No

Testing

No

@github-actions github-actions Bot added the Size: M The size of the change in this PR is medium label Oct 15, 2024
@nuttxpr
Copy link
Copy Markdown

nuttxpr commented Oct 15, 2024

[Experimental Bot, please feedback here]

No, this PR does not meet the NuttX requirements.

Missing Information:

  • Summary:
    • Lacks a clear explanation of the change's purpose (fix, update, feature).
    • Does not describe the functional code being changed.
    • Provides a vague description of the change's mechanics.
    • Omits issue references.
  • Impact:
    • Provides a simple "No" for all impact categories without justification. Some impacts (e.g., hardware, compatibility) are likely relevant given the code involved.
  • Testing:
    • Simply states "No" for testing.
    • Does not list build hosts or target environments used for verification.
    • Omits testing logs before and after the change.

To meet NuttX PR requirements, the author needs to:

  1. Expand the Summary:
    • Clearly state the PR's purpose.
    • Identify the specific code sections being modified.
    • Explain how the change addresses the "rootcause" and its effects.
    • Include relevant issue references.
  2. Thoroughly Address Impact:
    • Analyze and justify the impact (or lack thereof) for each category.
    • Provide specific details if an impact exists.
  3. Provide Testing Details:
    • Confirm testing on local setup and list specific build host and target details.
    • Include relevant testing logs from before and after the change to demonstrate the issue and the fix.

rootcause: in btuart_rxwork, read data in blocking mode and btuart_read do three times, maybe remote send some packets one time,so it wont read the sencond packets.

Signed-off-by: wangzhi7 <wangzhi7@xiaomi.com>
@GUIDINGLI
Copy link
Copy Markdown
Contributor

close, use PR: #14224

@GUIDINGLI GUIDINGLI closed this Oct 16, 2024
@W-M-R W-M-R deleted the bt branch October 16, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: Bluetooth Size: M The size of the change in this PR is medium

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants