Skip to content

ISSUE_TEMPLATE: fix missing labels#14435

Merged
raiden00pl merged 1 commit intoapache:masterfrom
simbit18:simbit18-issue
Oct 21, 2024
Merged

ISSUE_TEMPLATE: fix missing labels#14435
raiden00pl merged 1 commit intoapache:masterfrom
simbit18:simbit18-issue

Conversation

@simbit18
Copy link
Contributor

@simbit18 simbit18 commented Oct 21, 2024

Summary

Not all labels are added because there is no match with the label name.

issue_labeler.yml
os: Linux -> os: linux

001_bug_report.yml
Type: bug -> Type: Bug
Corrected label in links

002_feature_request.yml
Type: enhancement -> Type: Enhancement
Corrected label in links

003_help.yml
Type: question -> Community: Question
Corrected label in links

Impact

Impact on user: No changes to user-facing functionality
Impact on build: Build process remains the same

Testing

CI
https://github.com/simbit18/nuttx-testing-templates/issues

@github-actions github-actions bot added Area: CI Size: S The size of the change in this PR is small labels Oct 21, 2024
@nuttxpr
Copy link

nuttxpr commented Oct 21, 2024

[Experimental Bot, please feedback here]

This PR makes minor changes to the issue templates to correct typos and capitalization inconsistencies in labels.

Does it meet the requirements?

Mostly. Here's a breakdown:

  • Summary: ✅ Provides a clear reason for the change and what was modified.
  • Impact:
    • ✅ Accurately identifies no user-facing changes.
    • ✅ Correctly states no build process changes.
    • ➖ Could explicitly state "NO" for all other impact categories for completeness.
  • Testing:
    • ⚠️ Relies solely on CI testing. While CI is important, providing some local testing details, even if minimal, would strengthen the PR. Ideally, include examples of commands used to validate the template changes.

Recommendations:

  1. Explicitly state "NO" for all other impact categories. This leaves no room for ambiguity.
  2. Add brief local testing details. Even simple commands showing template usage demonstrate thoroughness.
  3. Consider adding a screenshot of the updated template in the PR description. This makes it easier for reviewers to visualize the changes without having to check out the code.

@simbit18
Copy link
Contributor Author

@raiden00pl
Copy link
Member

what about this: Community: Question Further information is requested ?

@simbit18
Copy link
Contributor Author

for 003_help.yml

labels: ["Type: question"]

@raiden00pl
Copy link
Member

can we change this to Community: Question ?

@simbit18
Copy link
Contributor Author

simbit18 commented Oct 21, 2024

@raiden00pl Ok done

Not all labels are added because there is no match with the label name.

issue_labeler.yml
os: Linux -> os: linux

001_bug_report.yml
Type: bug -> Type: Bug
Corrected label in links

002_feature_request.yml
Type: enhancement -> Type: Enhancement
Corrected label in links

003_help.yml
Type: question ->Type: Question
Corrected label in links
@raiden00pl raiden00pl merged commit 79073f0 into apache:master Oct 21, 2024
@simbit18 simbit18 deleted the simbit18-issue branch October 22, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: CI Size: S The size of the change in this PR is small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants