drivers/rpmsg: use nuttx/atomic.h instead metal/atomic.h #18036
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Area: Drivers
jerpelea
changed the title
jerpelea
approved these changes
Jan 20, 2026
xiaoxiang781216
approved these changes
Jan 20, 2026
All the atomic operation already changed to nuttx's, so change the include header too Signed-off-by: yintao <yintao@xiaomi.com>
CV-Bowen
force-pushed
the
rpmsg-atomic
branch
from
04a9df8 to
8c8de5a
Compare
Contributor
Author
|
Compile error with the nuttx-apps, un-related to this PR, force push to retrigger the CI ====================================================================================
Configuration/Tool: qemu-armv8a/rpserver
2026-01-20 09:38:13
------------------------------------------------------------------------------------
Cleaning...
/github/workspace/sources/apps/Application.mk:238: target 'signest.c.github.workspace.sources.apps.testing.ostest.o' given more than once in the same rule
/github/workspace/sources/apps/Application.mk:238: target 'signest.c.github.workspace.sources.apps.testing.ostest.o' given more than once in the same rule
Configuring...
Building NuttX...
cu_main.c: In function 'sigint':
Error: cu_main.c:128:33: error: 'siginfo' undeclared (first use in this function)
128 | FAR struct cu_globals_s *cu = siginfo->si_user;
| ^~~~~~~
cu_main.c:128:33: note: each undeclared identifier is reported only once for each function it appears in
make[2]: *** [/github/workspace/sources/apps/Application.mk:330: cu_main.c.github.workspace.sources.apps.system.cu.o] Error 1
make[2]: Target 'all' not remade because of errors.
make[1]: *** [Makefile:54: /github/workspace/sources/apps/system/cu_all] Error 2
make[1]: Target 'all' not remade because of errors.
make: *** [tools/LibTargets.mk:248: /github/workspace/sources/apps/libapps.a] Error 2
make: Target 'all' not remade because of errors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR replaces the
metal/atomic.hinclude withnuttx/atomic.hin the RPMSG header file to maintain consistency with NuttX's atomic operations implementation.The atomic operations in NuttX have been migrated to use NuttX's native atomic implementation. This change updates the include directive to reflect this migration:
Impact
Rpmsg
Testing
qemu-armv8a:rpserver and rpproxy