drivers/sensors/dhtxx: Fix read return values to be POSIX compliant #18164
+8
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the
readmethod in thedhtxxcharacter driver to comply with standard POSIX behavior.0on success, which does not conform to the standardreadinterface (which should return the number of bytes read). Additionally, it uses non-standard or incorrect error codes (e.g., returning-ENOSYSfor invalid arguments or generic-1).dhtxx_readto return the actual number of bytes read (sizeof(struct dhtxx_sensor_data_s)) on success.-1and incorrect-ENOSYSwith standard errno:-EINVALfor invalid buffer arguments.-ETIMEDOUTfor sensor timeouts.-EIOfor checksum verification or parsing failures.Impact
read()will now receive the correct byte count instead of0.Testing
I confirm that changes are verified on local setup and works as intended:
Testing logs before change:
Testing logs after change:
Test Source Code
dht11:PR verification Self-Check