-
Notifications
You must be signed in to change notification settings - Fork 1.5k
net/ipforward: it should have a ipforward setting based interface #18245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| * | ||
| ****************************************************************************/ | ||
|
|
||
| int ipforward_enable(FAR struct net_driver_s *dev) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where you call this function, please follow how IFUP get changed from userspace
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you give me more further info about this "how IFUP" get changed from userspace. is there any commit id or related topic for it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you already have this one, I think this PR can be abandoned, thanks : )
linguini1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fill out the PR description according to the template + contributing guidelines.
It's like option "net.ipv4.conf.eth0.forwarding". It's a useful setting if there are network interfaces like a lte modem. A lte modem usually has 3 net interfaces, while only one can be used data communication. It allows us configure the net device usage more flexible. Signed-off-by: Jerry Ma <shichunma@bestechnic.com>
|
@masc2008 please review #18260 (review), which implement the similiar and more functionality. |
Summary
It's like option "net.ipv4.conf.eth0.forwarding" in linux.
It's a useful setting if we need control ip forward by network interface level. Such like a LTE modem, a LTE modem usually has 3 net interfaces, while only one can be used data communication. It allows us configure the net device usage more flexible.
Impact
Testing
I confirm that changes are verified on local setup and works as intended:
Testing logs before change:
any device can be chosen as ipforward net interface.
Testing logs after change:
with this commit, only network interface with flag "IFF_FORWARD" can forward ip packet.
PR verification Self-Check