Skip to content

Conversation

@txy-21
Copy link
Contributor

@txy-21 txy-21 commented Feb 3, 2026

Summary

Add missing kmalloc.h header include to ARM64 architecture timer implementation.

Why:
The arch/arm64/src/common/arm64_arch_timer.c file uses kernel memory allocation functions but was missing the nuttx/kmalloc.h header include, causing compilation failures or implicit function declaration warnings in certain build configurations.

What changed:

  • Added #include <nuttx/kmalloc.h> to arch/arm64/src/common/arm64_arch_timer.c
  • Ensures proper declaration of memory allocation functions used by the timer subsystem

Impact

Scope:

  • ARM64 architecture: Fixed header dependency in timer subsystem
  • Compilation: Eliminates implicit function declaration warnings

Affected files:

  • arch/arm64/src/common/arm64_arch_timer.c - Architecture timer implementation

Breaking changes: None

Backward compatibility: Fully maintained - this is a build fix with no functional changes

Testing

Build testing:

# ARM64 configuration with arch timer
./tools/configure.sh qemu-armv8a:nsh_smp
make clean && make
# Build successful with no warnings

Include nuttx/kmalloc.h in arm64_arch_timer.c to fix missing header
dependency. This ensures proper memory allocation functions are
available for the architecture timer implementation.

Signed-off-by: hongfengchen <hongfengchen@xiaomi.com>
@github-actions github-actions bot added Arch: arm64 Issues related to ARM64 (64-bit) architecture Size: XS The size of the change in this PR is very small labels Feb 3, 2026
Copy link
Contributor

@linguini1 linguini1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to list affected files, they are shown in the diff!

@linguini1 linguini1 merged commit ac36320 into apache:master Feb 3, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Arch: arm64 Issues related to ARM64 (64-bit) architecture Size: XS The size of the change in this PR is very small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants