rptun: select SCHED_WAITPID as dependency#18415
Closed
mzanders wants to merge 1 commit intoapache:masterfrom
Closed
rptun: select SCHED_WAITPID as dependency#18415mzanders wants to merge 1 commit intoapache:masterfrom
mzanders wants to merge 1 commit intoapache:masterfrom
Conversation
simbit18
requested review from
anchao,
cederom,
jerpelea,
linguini1 and
raiden00pl
github-actions
bot
added
Area: Drivers
linguini1
reviewed
Feb 19, 2026
drivers/rptun/Kconfig
Outdated
| bool "Remote Proc Tunnel Driver Support" | ||
| default n | ||
| select RPMSG_VIRTIO | ||
| select SCHED_WAITPID |
Contributor
There was a problem hiding this comment.
It is preferred to use the depends on keyword here.
rptun.c calls nxsched_waitpid(). Make the dependency explicit to avoid build issues.
mzanders
force-pushed
the
rptun_dependency_fix
branch
from
fa1bec5 to
3bc7eec
Compare
cederom
requested changes
Feb 19, 2026
Contributor
There was a problem hiding this comment.
Aah, git commit sign missing (git commit -s plz) + build and runtime test logs required :-P
See https://github.com/apache/nuttx/blob/master/CONTRIBUTING.md :D
Contributor
Author
|
@cederom you're right on requesting a log. I tested on my board (iMX93 under development) which obviously was OK. But when testing for other builds (imx95-evk:rpmsg in this case), I got into dependency loop hell which I really can't trace down to where the dependency chain should be cut... :-( |
Contributor
|
This is why we prefer You may want to replace |
Contributor
|
No need to close this PR, go fight until the solution is found! :-) |
Contributor
Author
I'll be back. With even more fixes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rptun.c calls nxsched_waitpid(). Make the dependency explicit to avoid build issues.
Summary
Using RPTUN requires manual selection of SCHED_WAITPID which is
not obvious. Automate this through Kconfig.
Impact
None. Build fails when not SCHED_WAITPID selected in defconfig.
Testing
This is a trivial change.
Build rptun without SCHED_WAITPID > fails.
With fix, regenerate .config and build succeeds.