CI: Revert GitHub Actions for Docker, by hash#18575
Conversation
All CI Builds have been failing since 18 hours ago: - apache#18571 (comment) - https://github.com/apache/nuttx/actions/runs/23389990049 > _The action docker/login-action@v4 is not allowed in apache/nuttx because all actions must be from a repository owned by your enterprise, created by GitHub, or match one of the patterns: 1Password/load-secrets-action@13f58ee, 1Password/load-secrets-action@8d0d610, 1Password/load-secrets-action@dafbe7c, AdoptOpenJDK/install-jdk@*, BobAnkh/auto-generate-changelog@*, DavidAnson/markdownlint-cli2-action@07035fd, DavidAnson/markdownlint-cli2-action@30a0e04, EnricoMi/publish-unit-test-result-action@*, JamesIves/github-pages-deploy-action@4a3abc7, JamesIves/github-pages-deploy-action@d92aa23, Jimver/cuda-toolkit@6008063, Jimver/cuda-toolkit@b6fc3a9, JustinBeckwith/linkinator-action@af984b9f30f63e796..._ That's because ASF Infrastructure Team has mandated that we use the Hash Versions of GitHub Actions for Docker, stated below: - https://github.com/apache/infrastructure-actions/blob/main/actions.yml - Which generates: https://github.com/apache/infrastructure-actions/blob/main/approved_patterns.yml - Due to: apache/infrastructure-actions#547 ```yaml docker/build-push-action: 10e90e3645eae34f1e60eeb005ba3a3d33f178e8: tag: v6.19.2 docker/login-action: c94ce9fb468520275223c153574b00df6fe4bcc9: tag: v3.7.0 docker/metadata-action: c299e40c65443455700f0fdfc63efafe5b349051: tag: v5.10.0 docker/setup-buildx-action: 8d2750c68a42422c14e847fe6c8ac0403b4cbd6f: tag: v3.12.0 ``` This PR reverts our GitHub Actions for Docker to the hash versions stated above. Signed-off-by: Lup Yuen Lee <luppy@appkaki.com>
|
Yeah because c94ce9fb468520275223c153574b00df6fe4bcc9 is far more readable than v3.7.0 and also confirms it's a release :D :D |
|
@simbit18 FYI we need to update
|
|
Yep the ASF Policy Change is due to the Trivy Security Incident. Yesterday somehow I failed to understand the meaning of the exact words when I read this broadcast email (maybe
|
|
Yup, saw that too, better safe than sorry :-) |
|
I also had this idea once to verify master history against injected changes. This may come handy :-P Maybe there are projects like that already? :-) |
Summary
(Sorry to resubmit this PR. We must specify the GitHub Actions by Hash, not Version Number)
All CI Builds have been failing since 18 hours ago:
That's because ASF Infrastructure Team has mandated that we use the Hash Versions of GitHub Actions for Docker, stated below:
This PR reverts our GitHub Actions for Docker to the hash versions stated above.
Impact
All CI Builds will now be started correctly.
Testing
We tested the updated GitHub Actions for Docker in our own NuttX Repo. The CI Build runs successfully: