Skip to content

CI: Revert GitHub Actions for Docker, by hash#18575

Merged
simbit18 merged 1 commit intoapache:masterfrom
lupyuen14:fix-docker-actions2
Mar 22, 2026
Merged

CI: Revert GitHub Actions for Docker, by hash#18575
simbit18 merged 1 commit intoapache:masterfrom
lupyuen14:fix-docker-actions2

Conversation

@lupyuen
Copy link
Member

@lupyuen lupyuen commented Mar 22, 2026

Summary

(Sorry to resubmit this PR. We must specify the GitHub Actions by Hash, not Version Number)

All CI Builds have been failing since 18 hours ago:

The action docker/login-action@v4 is not allowed in apache/nuttx because all actions must be from a repository owned by your enterprise, created by GitHub, or match one of the patterns: 1Password/load-secrets-action@13f58ee, 1Password/load-secrets-action@8d0d610, 1Password/load-secrets-action@dafbe7c, AdoptOpenJDK/install-jdk@, BobAnkh/auto-generate-changelog@, DavidAnson/markdownlint-cli2-action@07035fd, DavidAnson/markdownlint-cli2-action@30a0e04, EnricoMi/publish-unit-test-result-action@*, JamesIves/github-pages-deploy-action@4a3abc7, JamesIves/github-pages-deploy-action@d92aa23, Jimver/cuda-toolkit@6008063, Jimver/cuda-toolkit@b6fc3a9, JustinBeckwith/linkinator-action@af984b9f30f63e796...

That's because ASF Infrastructure Team has mandated that we use the Hash Versions of GitHub Actions for Docker, stated below:

docker/build-push-action:
  10e90e3645eae34f1e60eeb005ba3a3d33f178e8:
    tag: v6.19.2
docker/login-action:
  c94ce9fb468520275223c153574b00df6fe4bcc9:
    tag: v3.7.0
docker/metadata-action:
  c299e40c65443455700f0fdfc63efafe5b349051:
    tag: v5.10.0
docker/setup-buildx-action:
  8d2750c68a42422c14e847fe6c8ac0403b4cbd6f:
    tag: v3.12.0

This PR reverts our GitHub Actions for Docker to the hash versions stated above.

Impact

All CI Builds will now be started correctly.

Testing

We tested the updated GitHub Actions for Docker in our own NuttX Repo. The CI Build runs successfully:

All CI Builds have been failing since 18 hours ago:
- apache#18571 (comment)
- https://github.com/apache/nuttx/actions/runs/23389990049

> _The action docker/login-action@v4 is not allowed in apache/nuttx because all actions must be from a repository owned by your enterprise, created by GitHub, or match one of the patterns: 1Password/load-secrets-action@13f58ee, 1Password/load-secrets-action@8d0d610, 1Password/load-secrets-action@dafbe7c, AdoptOpenJDK/install-jdk@*, BobAnkh/auto-generate-changelog@*, DavidAnson/markdownlint-cli2-action@07035fd, DavidAnson/markdownlint-cli2-action@30a0e04, EnricoMi/publish-unit-test-result-action@*, JamesIves/github-pages-deploy-action@4a3abc7, JamesIves/github-pages-deploy-action@d92aa23, Jimver/cuda-toolkit@6008063, Jimver/cuda-toolkit@b6fc3a9, JustinBeckwith/linkinator-action@af984b9f30f63e796..._

That's because ASF Infrastructure Team has mandated that we use the Hash Versions of GitHub Actions for Docker, stated below:
- https://github.com/apache/infrastructure-actions/blob/main/actions.yml
- Which generates: https://github.com/apache/infrastructure-actions/blob/main/approved_patterns.yml
- Due to: apache/infrastructure-actions#547

```yaml
docker/build-push-action:
  10e90e3645eae34f1e60eeb005ba3a3d33f178e8:
    tag: v6.19.2
docker/login-action:
  c94ce9fb468520275223c153574b00df6fe4bcc9:
    tag: v3.7.0
docker/metadata-action:
  c299e40c65443455700f0fdfc63efafe5b349051:
    tag: v5.10.0
docker/setup-buildx-action:
  8d2750c68a42422c14e847fe6c8ac0403b4cbd6f:
    tag: v3.12.0
```

This PR reverts our GitHub Actions for Docker to the hash versions stated above.

Signed-off-by: Lup Yuen Lee <luppy@appkaki.com>
@github-actions github-actions bot added Area: CI Size: XS The size of the change in this PR is very small labels Mar 22, 2026
Copy link
Contributor

@cederom cederom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @lupyuen :-)

@cederom
Copy link
Contributor

cederom commented Mar 22, 2026

Yeah because c94ce9fb468520275223c153574b00df6fe4bcc9 is far more readable than v3.7.0 and also confirms it's a release :D :D

@lupyuen
Copy link
Member Author

lupyuen commented Mar 22, 2026

@simbit18 FYI we need to update docker/login-action before June 2026, but after ASF has approved the new version (sigh): https://github.com/apache/nuttx/actions/runs/23392538906

Linux (risc-v-01)
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: docker/login-action@c94ce9f. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/

@lupyuen
Copy link
Member Author

lupyuen commented Mar 22, 2026

Yep the ASF Policy Change is due to the Trivy Security Incident. Yesterday somehow I failed to understand the meaning of the exact words when I read this broadcast email (maybe actions should have been stated explicitly as GitHub Actions): https://news.apache.org/foundation/entry/initial-report-on-trivy-security-incident

ASF Infra and ASF Security agreed to disable all previously allowed “verified creator” actions while the incident is being investigated

This may cause build failures, and require projects request newly-failed actions be added via the Infra GHA approval process: github.com/apache/infrastructure-actions?tab=readme-ov-file#adding-a-new-version-to-the-allow-list

@cederom
Copy link
Contributor

cederom commented Mar 22, 2026

Yup, saw that too, better safe than sorry :-)

@cederom
Copy link
Contributor

cederom commented Mar 22, 2026

I also had this idea once to verify master history against injected changes. This may come handy :-P Maybe there are projects like that already? :-)

@simbit18 simbit18 merged commit a84d263 into apache:master Mar 22, 2026
58 of 78 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: CI Size: XS The size of the change in this PR is very small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants