Merged
Conversation
install NTFC package from PIP Signed-off-by: raiden00pl <raiden00@railab.me>
use NTFC from pip for citest configs Signed-off-by: raiden00pl <raiden00@railab.me>
github-actions
bot
added
Area: CI
Size: S
lupyuen
approved these changes
Mar 26, 2026
Member
lupyuen
left a comment
lupyuen
left a comment
There was a problem hiding this comment.
I'm curious if these commands will ever fail due to Download Issues. @simbit18 and I will have to monitor this after rollout :-) FYI I'm building a new dashboard to monitor our PRs: https://youtu.be/J7w1gyjwZ1w?si=Ny8KoOQc6FF4ZJQ2&t=1745
pip install ntfc==0.0.1
git clone -b release-0.0.1 https://github.com/szafonimateusz-mi/nuttx-testing
simbit18
approved these changes
Mar 26, 2026
xiaoxiang781216
approved these changes
Mar 26, 2026
Member
|
Tested OK in my own repo thanks :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
install NTFC package from PIP. With this change we can skip the use of venv and the installation of system dependencies, thus limiting the amount of data downloaded
Impact
This aproach should be faster and more stable. The next step will be to install NTFC directly into the Docker image.
Testing
NTFC works correctly my priv fork https://github.com/raiden00pl/nuttx/actions/runs/23595750546/job/68712232540?pr=47#step:10:294