Skip to content

CMake: Improvements to CMakeLists.txt file#18743

Merged
lupyuen merged 2 commits intoapache:masterfrom
simbit18:simbit18-quiet
Apr 15, 2026
Merged

CMake: Improvements to CMakeLists.txt file#18743
lupyuen merged 2 commits intoapache:masterfrom
simbit18:simbit18-quiet

Conversation

@simbit18
Copy link
Copy Markdown
Contributor

@simbit18 simbit18 commented Apr 15, 2026

Summary

CMakeLists.txt:

  • Added QUIET option for Python package search

tools/CMakeLists.txt:

  • more aligned to the tools/Makefile.host file (added mkpasswd )

Impact

Impact on user: NO

Impact on build: NO

Impact on hardware: NO

Impact on documentation: NO

Impact on security: NO

Impact on compatibility: NO

Testing

locally and GitHub

https://github.com/simbit18/manual-nuttx-ci/actions/runs/24413670988/job/71317112841

@github-actions github-actions Bot added Area: Build system Size: S The size of the change in this PR is small labels Apr 15, 2026
The QUIET option turns off unnecessary informational messages.

Signed-off-by: simbit18 <simbit18@gmail.com>
lupyuen
lupyuen previously approved these changes Apr 15, 2026
fdcavalcanti
fdcavalcanti previously approved these changes Apr 15, 2026
- Add mkpasswd binaries

Signed-off-by: simbit18 <simbit18@gmail.com>
@simbit18 simbit18 dismissed stale reviews from fdcavalcanti and lupyuen via c2ddda2 April 15, 2026 13:54
@fdcavalcanti fdcavalcanti self-requested a review April 15, 2026 14:02
@simbit18
Copy link
Copy Markdown
Contributor Author

Hi @lupyuen, the retry function in case of error has been activated here!
https://github.com/apache/nuttx/actions/runs/24455781076/job/71456711049

@lupyuen
Copy link
Copy Markdown
Member

lupyuen commented Apr 15, 2026

Yep I saw that :-) I was wondering why NuttX Build Monitor blanked out the error for sim:note...

Screenshot_2026-04-15-22-34-31-377_com android chrome

@simbit18
Copy link
Copy Markdown
Contributor Author

NuttX Build Monitor is awesome I see it often.

@lupyuen lupyuen merged commit de87075 into apache:master Apr 15, 2026
41 checks passed
@lupyuen
Copy link
Copy Markdown
Member

lupyuen commented Apr 15, 2026

FYI the Download Retry works yay! :-)
https://github.com/apache/nuttx/actions/runs/24458547288/job/71466286165#step:10:1053

@simbit18 simbit18 deleted the simbit18-quiet branch April 16, 2026 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: Build system Size: S The size of the change in this PR is small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants