CI: Remove corrupted downloads for build retry#18763
Merged
lupyuen merged 1 commit intoapache:masterfrom Apr 19, 2026
Merged
Conversation
We have implemented CI Build Retry for mitigating Download Failures. But right now it will reuse any Corrupted Downloads (instead of deleting them), which will cause CI Build Retry to fail repeatedly: https://github.com/apache/nuttx/actions/runs/24611381081/job/71966407518#step:10:627 ``` Ignored files: system/argtable3/v3.2.0.7402e6e.tar.gz gzip: stdin: not in gzip format make[3]: *** [Makefile:76: argtable3] Error 2 ``` This PR proposes to change `git clean -fd` to `git clean -xfdq`. This will remove any Corrupted Downloads, preventing their reuse for CI Build Retry: ```bash ## Simulate a corrupted download for argtable3 $ tools/configure.sh qemu-armv8a/netnsh $ Downloading v3.2.0.7402e6e.tar.gz--argtable3 ## Press Ctrl-C to stop the build ## `git clean -fd` won't remove the corrupted download $ cd ../apps $ git clean -fd $ find . -name "v3.2.0.7402e6e.tar.gz" ./system/argtable3/v3.2.0.7402e6e.tar.gz ## `git clean -xfdq` removes the corrupted download $ git clean -xfdq $ find . -name "v3.2.0.7402e6e.tar.gz" ## Corrupted download is deleted correctly ``` `git clean -xfdq` is also found in the same testbuild script, so we are using it consistently: https://github.com/apache/nuttx/blob/12e8f92a282fac58e0dfff587ea3d9502e4804c0/tools/testbuild.sh#L286-L291 Signed-off-by: Lup Yuen Lee <luppy@appkaki.com>
1 task
Member
Author
|
@cederom All github.com downloads were failing really badly over the past 12 hours, not sure why. Even our NuttX Build Farm was affected, running on my Local PC outside GitHub Actions:
|
Contributor
|
Thank you so much for keeping an eye @lupyuen !! =) |
xiaoxiang781216
approved these changes
Apr 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
We have implemented CI Build Retry for mitigating Download Failures. But right now it will reuse any Corrupted Downloads (instead of deleting them), which will cause CI Build Retry to fail repeatedly: https://github.com/apache/nuttx/actions/runs/24611381081/job/71966407518#step:10:627
This PR proposes to change
git clean -fdtogit clean -xfdq. This will remove any Corrupted Downloads, preventing their reuse for CI Build Retry:git clean -xfdqis also found in the same testbuild script, so we are using it consistently:nuttx/tools/testbuild.sh
Lines 286 to 291 in 12e8f92
Impact
CI Build Retry will now work correctly, retrying any Failed Downloads, instead of reusing them.
Testing
We tested a Normal Build (without errors), since Download Failures are unpredictable and hard to simulate:
We hope to eliminate these Download Errors that we see in NuttX Build Monitor: https://lupyuen.github.io/nuttx-github-jobs/build-monitor